From: Andrew Cooper Date: Tue, 28 Jul 2015 21:44:37 +0000 (+0100) Subject: tools/libxl: Assert that libxl__ao_inprogress_gc() is not called with NULL X-Git-Tag: archive/raspbian/4.8.0-1+rpi1~1^2~2664 X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/success//%22http:/www.example.com/cgi/success/?a=commitdiff_plain;h=371e7eff4b067f3ec923a49f1c446b8169e7d701;p=xen.git tools/libxl: Assert that libxl__ao_inprogress_gc() is not called with NULL libxl__ao_inprogress_gc() is hidden behind various macros used to construct local variables. Assert() that NULL is not passed, to make such an error very obvious, rather than a plain segfault at 0. No functional change. Signed-off-by: Andrew Cooper Acked-by: Ian Jackson --- diff --git a/tools/libxl/libxl_event.c b/tools/libxl/libxl_event.c index 8acecfa544..bfb6b31a7f 100644 --- a/tools/libxl/libxl_event.c +++ b/tools/libxl/libxl_event.c @@ -1862,6 +1862,7 @@ void libxl__ao_create_fail(libxl__ao *ao) libxl__gc *libxl__ao_inprogress_gc(libxl__ao *ao) { + assert(ao); assert(ao->magic == LIBXL__AO_MAGIC); assert(!ao->complete); return &ao->gc;